Whats wrong with this callback?

[KingSnail]

I recently added the mass check to the custom character controller so two controllers dont collide together.
No matter what, Newton allways crashes when using the FIndFloor convex cast using this prefilter:
Does this need critical sections or something? because I thought NewtonBodyGetMassMatrix simply reads values.

Code: Select all

unsigned CustomPlayerController::ConvexAllBodyCastPrefilter(const NewtonBody* body, const NewtonCollision* collision, void* userData)
{
   CastFilterData* filterData;
   filterData = (CastFilterData*) userData;

   for(int i = 0; i < filterData->m_count; ++i)
   {
      if(filterData->m_filter[i] == body)return 0;
   }

   if(body)
   {
      dFloat mass;
      dFloat Ixx;
      dFloat Iyy;
      dFloat Izz;
      //NewtonWorldCriticalSectionLock(
      NewtonBodyGetMassMatrix(body, &mass, &Ixx, &Iyy, &Izz);
      if(mass > 99.0f)return 0;
   }

   return 1;
}


[ledahut]

Your code seems ok.

I am not sure but when I used convexcast prefilter callback (only one body in my world: the floor), I watched body address (with breakpoint) in the callback and it was always different to my floor body address. And every newton function on this body address crashed.
Like your

NewtonBodyGetMassMatrix(body, &mass, &Ixx, &Iyy, &Izz);

Just check (in you application) what I am saying and report bug (if it is true) to the appropriate sub forum.

ps: I don't have my old project with convexcast anymore

[KingSnail]

hmm interesting thanks.
I am interested what Julio says to this.

[Julio Jerez]

the first thong I would try is set thread count to one and see if still crash.

[KingSnail]

Thread count 8: Crash after 3 minutes
Thread count 1: No crash after an hour

[Julio Jerez]

I do not think there is any wrong in the call back, unless it coping data to the shared memory.
The call back is call from these line in file
d:\Temp\newton-dynamics\packages\dCustomJoints\CustomPlayerController.cpp
contactCount = NewtonWorldConvexCast (m_world, &bodyMatrix[0][0], &destination[0], m_bodySensorShape, &hitParam, &castFilterData, ConvexStaticCastPrefilter, info, sizeof (info) / sizeof (info[0]), threadIndex);
in function CalculateVelocity and PlayerOnFreeFall
can you wrap the call with newton Critical section and see if is work.
That is not teh solution by it will expose if the Bug is in NewtonWorldConvexCast or in the Player controlle joint.
I do not think it is in the NewtonWorldConvexCast because that function the engine used, but if it is we can find it.

[KingSnail]

How am I supposed to get NewtonWorld to enter critical section?

[Julio Jerez]

these are the functions for critical sections

NewtonWorldCriticalSectionLock (const NewtonWorld* const newtonWorld);

NewtonWorldCriticalSectionUnlock (const NewtonWorld* const newtonWorld);

[KingSnail]

Sorry there was a confusion, I meant how do I get the actual NewtonWorld pointer?
Because if i do NewtonBodyGetWorld() it might cause race condition?
I basicly need to access NewtonWorld * from that callback in order to enter critical section.
And all this code is inside CustomCharacterController which I am not familiar with.

[JernejL]

newtoncreate makes a pointer to newtonworld, the pointer should be same across any thread and be valid in all its callbacks.

[KingSnail]

Yea but doesnt that create a new newton world?
As far as I understand, in my application, I make NewtonWorld and add bodies to it,
The character controller code does not have anything to do with the world, just manipulates bodies.
Does this mean I need to modify the character controller code in newton folder to save a pointer to the NewtonWorld?

[Julio Jerez]

The player controller is a joint, and joint has pointer to the body, you can get the body and with teh body you can call NewtonBodyGetWorld()

It is temporary solution until I find out what is wrong, and to see if thsi si what is wrong

[Stucuk]

Yea but doesnt that create a new newton world?

Delfi just means that you can store the World's Pointer as a global variable and use it for anything that needs it.

[KingSnail]

Well I tried it with the critical section and its causing real weirdness.
Controller seems stuck in the ground now.
I guess I will have to work with 1 Newton thread until theres some sort of bugfix.