Crash on vehicle deletion

[pHySiQuE]

This is how my vehicle gets deleted:

Code: Select all

   NewtonDynamicsVehicle::~NewtonDynamicsVehicle()
   {
      if (vehicle)
      {
         manager->DestroyController(vehicle);
         vehicle = NULL;
      }
      delete manager;
   }

When the body gets deleted, after the above code is run, I get this error:

Image1.jpg (179.07 KiB) Viewed 2542 times

[Julio Jerez]

Code: Select all

 NewtonDynamicsVehicle::~NewtonDynamicsVehicle()
   {
      if (vehicle)
      {
         manager->DestroyController(vehicle);
         vehicle = NULL;
      }

//what is this?
      delete manager;
   }


I do not remember that on any newton code. why do you delete the manager when you delete a controller?
how did that ever work?
basically the vehicle will work one time and will crash on delete because you call delete the manage from the own callback itself, upon return the pointer to the manager will be garbage.

Even if Manager pointe it not used in return, this mean you are doing the worse of all possible implementation, you are using one manager per vehicle.

[pHySiQuE]

So I should use one vehicle manager per newton world, and deleting the world will automatically delete the manager?

[Julio Jerez]

No,

Managers are a convenient way for grouping simulations be types. you can group then any way you want but grouping one vehicle one manager is the worse thing you can do.
you could simple make one vehicle manager and have the world destroying it if you want.

a Manager is not different than the collision system which hold collision shape and apply simila functions to those eobjects, or the dynamics manager that hold dynamics bodies and so on.
but if you make one manage per vehicle you are serializing the simulation, it will be like making every static collision a scene collision.

when you create a manager you know when you deleted it,
I do no remember but I believe the engine does not delete them.
you can think of the vehicle manager as the world for vehicles.