Can't compile

A place to discuss everything related to Newton Dynamics.

Moderators: Sascha Willems, walaber

Re: Can't compile

Postby Julio Jerez » Fri May 06, 2016 3:10 pm

d.l.i.w wrote:I'm not totally sure, but I think the dVisualDebuggerServer isn't even needed any more (Julio?) - I will check asap and update the CMake files accordingly..


yes this is correct, we should probably remove it for the build and remove altogether.
Julio Jerez
Moderator
Moderator
 
Posts: 12249
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: Can't compile

Postby d.l.i.w » Fri May 06, 2016 3:27 pm

Ok. I will remove it from the CMake files and create a pull request tomorrow.

It probably would be a good idea indeed, to also remove the actual code and enet - less code means better overview.
d.l.i.w
 
Posts: 81
Joined: Mon Sep 26, 2011 4:35 am

Re: Can't compile

Postby Julio Jerez » Fri May 06, 2016 4:48 pm

agree. I will do when you submit the request.
Julio Jerez
Moderator
Moderator
 
Posts: 12249
Joined: Sun Sep 14, 2003 2:18 pm
Location: Los Angeles

Re: Can't compile

Postby d.l.i.w » Sat May 07, 2016 4:27 pm

Latest revision does not compile - again:

Code: Select all
In file included from coreLibrary_300/source/core/dgSPDMatrix.cpp:25:0:
coreLibrary_300/source/core/dgSPDMatrix.h: In member function ‘bool dgLCP<T, Size>::SolveDantzig()’:
coreLibrary_300/source/core/dgSPDMatrix.h:672:38: error: there are no arguments to ‘CholeskyFactorizationAddRow’ that depend on a template parameter, so a declaration of ‘CholeskyFactorizationAddRow’ must be available [-fpermissive]
    CholeskyFactorizationAddRow (index);
                                      ^


I will create a pull request as soon as I can test my changes.
d.l.i.w
 
Posts: 81
Joined: Mon Sep 26, 2011 4:35 am

Re: Can't compile

Postby Stucuk » Sat May 07, 2016 4:37 pm

d.l.i.w wrote:I wrote release build - I meant a binary release.


My understanding is that as Newton is Open Source and that you can get free versions of Visual Studio/etc that Julio doesn't bother with binaries as people can compile there own.

It was only really when Newton was Closed Source that you saw alot of Binaries from Julio.
User avatar
Stucuk
 
Posts: 801
Joined: Sat Mar 12, 2005 3:54 pm
Location: Scotland

Re: Can't compile

Postby d.l.i.w » Sat May 07, 2016 4:45 pm

@Stucuk
Yes - and it's ok as is.

But you initially wrote:
It may be a good idea to have some stable Work In Progress builds

So I wondered why you want to have stable WIP builds if there even are no release builds (which is totally ok for me).
Probably you wanted to suggest stable WIP releases or git tags.

Sorry for nitpicking, but there is a difference :wink:
d.l.i.w
 
Posts: 81
Joined: Mon Sep 26, 2011 4:35 am

Re: Can't compile

Postby Stucuk » Sat May 07, 2016 6:02 pm

d.l.i.w wrote:So I wondered why you want to have stable WIP builds if there even are no release builds (which is totally ok for me).
Probably you wanted to suggest stable WIP releases or git tags.

Sorry for nitpicking, but there is a difference :wink:


I didn't mean to use the word builds (People do at times make mistakes). I just meant stable source code people could compile which is of the current wip version.

While you seem to be able to view the entire repository from a point in the past, you have no real way to know when it was last stable.
User avatar
Stucuk
 
Posts: 801
Joined: Sat Mar 12, 2005 3:54 pm
Location: Scotland

Re: Can't compile

Postby d.l.i.w » Sun May 08, 2016 7:10 am

Git "tags" can do, what you suggest, with little effort:
One could for example create tags for beta versions like "newton-3.14-beta1".

On Github the list of all tags can be found at
https://github.com/MADEAPPS/newton-dynamics/tags
and one can easily download the whole source code for each tag.
The git command line tool can also checkout the source code for a specific tagged revision.

Btw. "releases" on Github also are git tags, that are additionally marked as release.
d.l.i.w
 
Posts: 81
Joined: Mon Sep 26, 2011 4:35 am

Previous

Return to General Discussion

Who is online

Users browsing this forum: No registered users and 6 guests

cron